Repository navigation
feat: join the collector network with the endpoint off - #59
Merged
Merged
Conversation
Generated-by: LLM effort=high;harness=codex:0.164.0;model=openai:gpt-6.1-sol;session=sha-256-64:50c3c07b7a56a6ff;surface=exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recorder needs a collector to send metrics to. The collector runs on the deploy host, on a Compose network that already exists there. Its name belongs to the host, so it stays out of this repository.
Behavior change
Compose requires
METRICS_NETWORKand joins the receiver to that external network. Only the receiver joins it, and the tunnel stays onedge.OTEL_EXPORTER_OTLP_ENDPOINTpasses through from the environment and is empty by default. The worker keeps refusing entries for an empty value. A non-empty value starts the drain of the stored queue, as the new header comments note.Verification
The full Bazel test run passed with 30 tests and one skipped. New deploy tests check the empty default, the external network, and that only the receiver joins it.
Opened-by: LLM effort=medium;harness=claude-code:2.1.325;model=anthropic:claude-sonnet-5-5;session=sha-256-64:6507fa80a17e0653;surface=cli
Generated-by: LLM effort=high;harness=codex:0.164.0;model=openai:gpt-6.1-sol;session=sha-256-64:50c3c07b7a56a6ff;surface=exec
Assisted-by: LLM effort=medium;harness=claude-code:2.1.325;model=anthropic:claude-sonnet-5-5;session=sha-256-64:6507fa80a17e0653;surface=cli