Repository navigation
feat: record queued events with a metrics endpoint - #58
Merged
Merged
Conversation
Generated-by: LLM effort=high;harness=codex:0.164.0;model=openai:gpt-6.1-sol;session=sha-256-64:1227ca83b5e17814;surface=exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part A added the recorder. This change connects it to the command, so the queue can drain once metrics have a destination.
Behavior change
The command sets up telemetry at startup. With
OTEL_EXPORTER_OTLP_ENDPOINTpresent, the worker uses the real recorder and removes an entry after the recorder counts it. Without the variable, the worker keeps the refusing placeholder and every entry remains queued. A startup log line names the mode. It omits the endpoint. Telemetry shuts down after the worker stops, which flushes the final metrics.Verification
The full Bazel test run passed with 30 tests and one skipped. New command tests cover both modes and the refusing placeholder.
Opened-by: LLM effort=medium;harness=claude-code:2.1.325;model=anthropic:claude-sonnet-5-5;session=sha-256-64:6507fa80a17e0653;surface=cli
Generated-by: LLM effort=high;harness=codex:0.164.0;model=openai:gpt-6.1-sol;session=sha-256-64:1227ca83b5e17814;surface=exec
Assisted-by: LLM effort=medium;harness=claude-code:2.1.325;model=anthropic:claude-sonnet-5-5;session=sha-256-64:6507fa80a17e0653;surface=cli