Skip to content

feat: record queued events as metrics - #57

Merged
tbhb-agent merged 1 commit into
mainfrom
gm-recorder
Nov 15, 2026
Merged

tbhb-agent merged 1 commit into
mainfrom
gm-recorder

Conversation

@tbhb-agent

Copy link
Copy Markdown
Collaborator

Why

The queue stores a large backlog of deliveries, and the worker refuses every one until a real recorder exists. This change adds that recorder. A later change wires it into the command, so nothing leaves the queue yet.

Behavior change

The worker hands each entry's event name and body to the recorder and no longer parses bodies itself. A new recorder package counts deliveries as OpenTelemetry metrics. The counters are github.events, github.pr.merges, github.check.conclusions, and github.events.dropped. A delivery with an empty event name or an invalid body counts as a drop and leaves the queue. The command still uses the refusing placeholder. Attributes hold repository, event, action, check name, and conclusion. Titles, bodies, comments, and logins stay out.

Verification

The full Bazel test run passed with 29 passed and 1 skipped. The recorder tests read an in-memory reader for every counter and both drop reasons.

Opened-by: LLM effort=medium;harness=claude-code:2.1.325;model=anthropic:claude-sonnet-5-5;session=sha-256-64:6507fa80a17e0653;surface=cli
Generated-by: LLM effort=high;harness=codex:0.164.0;model=openai:gpt-6.1-sol;session=sha-256-64:ca12ec0da8efeef9;surface=exec
Assisted-by: LLM effort=medium;harness=claude-code:2.1.325;model=anthropic:claude-sonnet-5-5;session=sha-256-64:6507fa80a17e0653;surface=cli

Generated-by: LLM effort=high;harness=codex:0.164.0;model=openai:gpt-6.1-sol;session=sha-256-64:ca12ec0da8efeef9;surface=exec
@tbhb-agent
tbhb-agent merged commit 5326125 into main Nov 15, 2026
8 checks passed
@tbhb-agent
tbhb-agent deleted the gm-recorder branch November 15, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant