Repository navigation
sudo_ldap_check_non_unix_group: don't treat a group plugin error as a match - #582
Merged
Merged
Conversation
… match group_plugin_query() returns the plugin's query() result unchanged, and a group plugin may return a negative value on error (the Python group plugin returns SUDO_RC_ERROR when the lookup raises). The LDAP %:group check tested the result for non-zero, so a failed lookup granted the sudoRole. Compare against true, as usergr_matches() does for the same rule in a sudoers file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudo_ldap_check_non_unix_group() grants an LDAP sudoUser value of the form %:group whenever group_plugin_query() returns non-zero. group_plugin_query() passes the plugin's query() result through unchanged, and the Python group plugin returns SUDO_RC_ERROR (-1) when its lookup raises, so a sudoRole with sudoUser: %:admins is granted to a user whose group lookup failed. The same rule in a sudoers file is denied, because usergr_matches() in match.c requires == true.
Compare the result against true, matching match.c. This is the only caller that tests the result for non-zero, and keeping the check here means a plugin error fails closed for LDAP rules the same way it already does for sudoers rules.