Repository navigation
Conversation
The dual-time handling in LoadRestart covered FLOW and TURB but not TRANS, and the time levels in CTransLMVariable started at zero. Push TRANS_SOL to time levels n and n-1, load its second restart file on 2nd-order restarts, and initialise the time levels from the initial state when dual time stepping is on. Fixes su2code#2993 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
A dual-time run started from a steady solution, or restarted, loses the LM transition state.
CFVMFlowSolverBase::LoadRestart's dual-time handling covers FLOW and TURB but not TRANS, and the time levels inCTransLMVariablestart at zero. The first physical step then sees a wrongSolution_time_n/Solution_time_n1for the LM equations.This PR:
TRANS_SOLto time levels n and n-1 alongside FLOW and TURB;Solution_time_nandSolution_time_n1from the initial state inCTransLMVariablewhen dual time stepping is on.Test
2-D RG14 airfoil, Re 2e5, alpha 1.97 deg, SST + LM,
DUAL_TIME_STEPPING-2ND_ORDER, no multigrid. I ran 10 physical steps continuously and compared them with 9 steps + restart + 1 step, using the same steady seed for both.Values at step 10, continuous vs restarted:
With this PR, all residuals, CL and CD at step 10 match to the printed digits, for both
WRT_RESTART_COMPACTYES and NO.Limits of this test:
Related Work
Fixes #2993.
PR Checklist
pre-commit run --allto format old commits.This fix was written with AI assistance (Claude) and tested by running the case above.
🤖 Generated with Claude Code