Repository navigation
build: add warning guard for MinGw and MS-MPI on windows - #2997
Closed
nandininmmahesh-dotcom wants to merge 1 commit into
Closed
nandininmmahesh-dotcom wants to merge 1 commit into
nandininmmahesh-dotcom wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add a Meson build warning when building SU2 on Windows with MinGW GCC and MS-MPI enabled. This warns users that linking may fail without libmsmpi.a and suggests using MSVC or generating a MinGW import library instead.
Related Work
Ports the fix from SU2#1468 (branch fix/mingw-mpi-warning) to SU2-dev.
PR Checklist