Repository navigation
Conversation
|
Co-authored-by: jacobp100 <7275322+jacobp100@users.noreply.github.com>
Co-authored-by: jacobp100 <7275322+jacobp100@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix flex-flow handling of reverse keywords
Preserve reverse keywords in flex-flow
Nov 13, 2026
jacobp100
approved these changes
Nov 16, 2026
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the flex-flow keyword-matching fix.
No open issues 🎉
What changed in this PR
Fixes #215 by preserving complete reverse keywords when converting the flex-flow shorthand to React Native styles.
Changes:
- Anchors direction and wrap matchers to accept only complete keywords.
- Adds regression tests for reverse keywords, both shorthand orders, default values, and invalid partial matches.
| File | Description |
|---|---|
src/transforms/flexFlow.ts |
Anchors keyword matchers to prevent truncation and partial matches. |
src/__tests__/flexFlow.ts |
Tests reverse values, shorthand ordering, defaults, and invalid inputs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flex-flowtruncates reverse keywords because its matchers accept keyword prefixes.flex-flowdrops-reverse:column-reversebecomescolumn,wrap-reversebecomeswrap#215