Skip to content

Run ShellCheck on scripts and composite action steps - #100

Open
Frawless wants to merge 1 commit into
frawless/fix-scorecard-findingsfrom
frawless/add-shellcheck-lint
Open

Frawless wants to merge 1 commit into
frawless/fix-scorecard-findingsfrom
frawless/add-shellcheck-lint

Conversation

@Frawless

Copy link
Copy Markdown
Member

Type of Change

  • Task

Description

actionlint only checks run: steps in workflows, so the shell code in composite actions and in the .sh scripts was never linted. This adds .github/tests/shellcheck.sh (also runnable locally) and a shellcheck job in lint.yml.

  • Checks all .sh files and every run: step of .github/actions/*/*/action.yml; ${{ }} expressions are replaced by a placeholder, like actionlint does.
  • Fails on warning severity and above. Info-level findings (mostly unquoted variables, some of them intentional word splitting) are left for later.
  • Fixes the 7 existing warnings (unused loop variables, unneeded sudo, unquoted command substitutions, a unicode quote, GPG_TTY handling in push-to-central.sh).

Checklist

  • Update documentation
  • Write tests
  • Make sure all tests pass
  • Try your changes inside a Kubernetes cluster, not just from unit tests
  • AI assistance was used to create this PR (see the Strimzi AI policy)

Stack created with GitHub Stacks CLI • Give Feedback 💬

@Frawless
Frawless added this pull request to stack #105 November 13, 2026 18:47
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless
Frawless force-pushed the frawless/add-shellcheck-lint branch from 20f92ce to 27f666b Compare November 13, 2026 19:15
@Frawless
Frawless requested a review from a team November 13, 2026 20:25
@Frawless Frawless added this to the 4.0 milestone Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants