Repository navigation
build: restore test-file ESLint rule overrides - #16355
Merged
Merged
Conversation
The flat config migration dropped several rule overrides which the legacy `etc/eslint/.eslintrc.tests.js` applied to test files. Notably, without disabling `stdlib/jsdoc-doctest`, ESLint executes test files in a VM context, thus running the tests themselves and crashing on native tests when an addon is not available.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: skipped
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
kgryte
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
etc/eslint/.eslintrc.tests.jsconfigured the following rules for test files, but the**/test/**/*.jsblock ineslint.config.jsdid not carry them over:stdlib/jsdoc-doctest:offstdlib/no-unnecessary-nested-functions:offstdlib/jsdoc-private-annotation:offstdlib/no-single-property-require:offno-new-wrappers:warnWithout disabling
stdlib/jsdoc-doctest, ESLint evaluates each test file in a VM context, which runs the tape tests during linting and crashes ESLint on native tests when an addon is not available (e.g.,TypeError: ellipj is not a function). Without disablingstdlib/no-unnecessary-nested-functions, the nestedbadValuehelpers used throughout argument-validation tests are flagged. As a result, "Lint Changed Files" currently fails on any PR touching such test files (e.g., #14788, #15972, #16132, #16141, #16166).Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
etc/eslint/.eslintrc.tests.js)Questions
No.
Other
Verified locally:
eslint lib/node_modules/@stdlib/math/base/special/ellipj/test/test.native.jsexits with code 2 and prints TAP output ondevelop, and lints cleanly with this change.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code.
@stdlib-js/reviewers
🤖 Generated with Claude Code