Skip to content

feat: add slice method to array/fixed-endian-factory - #16345

Open
sarthakkaushik927 wants to merge 2 commits into
stdlib-js:developfrom
sarthakkaushik927:feat/fixed-endian-factory-slice
Open

sarthakkaushik927 wants to merge 2 commits into
stdlib-js:developfrom
sarthakkaushik927:feat/fixed-endian-factory-slice

Conversation

@sarthakkaushik927

@sarthakkaushik927 sarthakkaushik927 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Resolves #3154.

Description

What is the purpose of this pull request?

This pull request:

  • adds a slice method to array/fixed-endian-factory, which copies a portion of a fixed-endian typed array to a new typed array having the same byte order.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • array/complex64
  • array/fixed-endian-factory (existing with method)

What carried over from the reference(s)?

  • argument validation and index resolution/clamping semantics from Complex64Array.prototype.slice
  • test, benchmark, and README structure from the existing with method in array/fixed-endian-factory

What differed, or what did you have to work out yourself?

  • elements are copied element-wise via the data view getter/setter so that the returned array has its own buffer and preserves the byte order of the source array.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution.

I used Claude Code to help generate the tests, benchmarks, and documentation. I reviewed all changes and ran the package tests, examples, and benchmarks locally.


@stdlib-js/reviewers

Closes: stdlib-js#3154

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: sarthakkaushik927 <sarthakkaushik927@gmail.com>
@sarthakkaushik927
sarthakkaushik927 requested a review from a team October 29, 2026 05:28
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Oct 29, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

Copy the underlying bytes directly instead of copying element-by-element
via accessors, and avoid testing private properties.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: sarthakkaushik927 <sarthakkaushik927@gmail.com>
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add slice method to array/fixed-endian-factory

2 participants