Skip to content

refactor: rename variable - #16344

Merged
kgryte merged 1 commit into
developfrom
claude/cool-johnson-4qkdpf
Oct 29, 2026
Merged

kgryte merged 1 commit into
developfrom
claude/cool-johnson-4qkdpf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • renames the isSymbol identifier in assert/is-bigint/lib/main.js to isBigInt.

assert/is-bigint

lib/main.js binds the main export to isSymbol, a copy-paste leftover from assert/is-symbol. Its contents are otherwise identical to is-symbol/lib/main.js. The local identifier now matches the package name, as it does in 313 of 325 @stdlib/assert packages that have a lib/main.js (96%), and as it already does in this package's index.js, generic.js, and polyfill.js. The exported API and behavior do not change.

Related Issues

Does this pull request have any related issues?

None.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • assert/is-symbol
  • assert/is-boolean

What carried over from the reference(s)?

  • The lib/main.js convention: the local identifier matches the package name.

What differed, or what did you have to work out yourself?

  • Nothing.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This change came from an automated drift scan of @stdlib/assert (350 packages). The scan compared structural features (file tree, package.json keys, README sections) and semantic features (error construction, JSDoc tags, export identifiers) against a 75% majority threshold. This was the only finding that held up. The other deviations were left alone because they are deliberate:

  • Environment-constant packages have no benchmarks.
  • The is-*-array packages are built in index.js and have no lib/main.js.
  • contains throws a plain-string error. This is correct under stdlib/no-unnecessary-format.
  • Several packages use abbreviated export names, e.g. hasOwnProp and isEmail.

An independent reviewer confirmed the change is behavior-neutral. No test, example, or README in the package refers to isSymbol.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, as part of an automated cross-package API drift scan.



Generated by Claude Code

Renamed the `isSymbol` identifier in `lib/main.js` to `isBigInt`, matching
the package name (313 of 325 siblings with a `lib/main.js`, 96%) and the
identifier used in the package's own `index.js`, `generic.js`, and
`polyfill.js`. The identifier was a copy-paste leftover from
`assert/is-symbol`. No change to the exported API or behavior.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD78rZhnUBvHsiaxHY5e
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/is-bigint $\\color{green}366/366$
$\\color{green}+100.00\\%$
$\\color{green}17/17$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}366/366$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review October 29, 2026 10:51
@kgryte
kgryte requested a review from a team October 29, 2026 10:51
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 29, 2026
@kgryte kgryte changed the title refactor: rename misnamed local identifier in assert/is-bigint refactor: rename variable Oct 29, 2026
@kgryte
kgryte merged commit a3c5b97 into develop Oct 29, 2026
34 checks passed
@kgryte
kgryte deleted the claude/cool-johnson-4qkdpf branch October 29, 2026 10:52
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants