Repository navigation
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
|
|
||
| t.strictEqual( out, ws, 'returns expected value' ); | ||
| t.strictEqual( String( getDType( out ) ), 'float64', 'returns expected value' ); | ||
|
|
There was a problem hiding this comment.
I suggest actually testing the workspace contents here.
| t.strictEqual( String( getDType( out ) ), 'float32', 'returns expected value' ); | ||
|
|
||
| t.end(); | ||
| }); |
There was a problem hiding this comment.
I think you also should test for a "generic" output array.
|
|
||
| t.strictEqual( String( getDType( ws ) ), 'float32', 'returns expected value' ); | ||
| t.deepEqual( getShape( ws ), [ 42 ], 'returns expected value' ); | ||
|
|
There was a problem hiding this comment.
I suggest testing for the values here.
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
As discussed, let's move this package to fft/fftpack/rffti, as this API is FFTPACK-specific.
|
@kgryte I have now updated the tests to check for the values inside the workspace array, for |
Done. |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves a part of stdlib-js/metr-issue-tracker#1385.
Description
This pull request:
fft/fftpack/rffti, which will be helpful for feat: addfft/rfftf#16089.Related Issues
This pull request has the following related issues:
fft/rfftfmetr-issue-tracker#1385.Reference Packages
This pull request followed these packages:
blas/ext/one-to.Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used Claude code to help with implementation and research, and then did a manual review.
@stdlib-js/reviewers