Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages are tracked under the domain they were requested from, but invalidation resolves URLs in the current process. In a queue worker there's no request, so a relative site URL (
/) resolves againstAPP_URL; if that differs at all from the real origin (e.g.http://localhostvshttps://www.example.com), nothing is found and the page stays stale.synconly works because the CP request happens to share the frontend's origin.Each site now records the domains it has been cached under (
static-cache:site-domains), and invalidating a URL also checks every domain recorded for that URL's site. Other sites' domains are left alone. Background recache still only warms the domain the URL resolves to; matches under other recorded domains are invalidated instead, since those hosts come from request headers and shouldn't receive the recache token.Closes #3291