Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entries in a mounted collection only got new URIs when the mount entry itself was saved. If the mount's URI changed any other way (a parent's slug changed, or it was moved in the tree), the mounted entries kept their old URIs, e.g.
/about/blog/onestill resolved and/info/blog/one404'd until the Stache was rebuilt. That's the "mount randomly missing / URLs change after a while" behaviour in the later comments on #3625.Collection::updateEntryUris()now also updates any collection mounted on one of the updated entries, so every path that refreshes structured URIs (child page updates, tree saves, tree file changes) cascades. Ids are compared by root, since a tree save passes localization ids while the mount is stored as the origin.