Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
slug(ortitle,date,author) to "Hidden by default" still shows the column in the listing.hiddenis thelistabledefault, so the blueprint editor strips it on save, andField::isVisibleOnListing()treats a missinglistableon these four handles as "show".FieldTransformernow keepslistableon save for these handles, and prefillslistable: truewhen loading them into the editor so it shows what the listing actually does. Other fields keep their trimmed YAML.Re-saving an untouched
slugnow writeslistable: true. Blueprints where "Hidden" was already stripped aren't migrated; the editor now shows them as "Shown by default" so they can be re-set.Closes #10792