Repository navigation
Conversation
edalzell
marked this pull request as ready for review
November 15, 2026 00:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing a collection's
sitesdidn't refresh its Stache entries store. Entry paths are filtered by the collection's sites only when they're built, then cached, soCollectionSavedlisteners (and the rest of the request) still got entries from the old sites. With the watcher off it stayed wrong untilstache:refresh.The Stache
CollectionRepository::save()now clears that collection's entries store whensitesis dirty, so it rebuilds with the new sites on next use.The test uses a serializing cache store: the plain array store hands back the collection being saved, and fetching it resets its dirty state mid-save.
Closes #10344