Repository navigation
[6.x] Fix files outside the root being treated as within it - #15886
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he root Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FilesystemAdapter::isWithinRoot()didn't resolve..segments, so paths like../file.txtorrelative/../../file.txtwere considered inside the root. It also compared prefixes without a trailing separator, so a sibling directory like<root>-old/file.txtpassed too.This affected
{{ theme:output }}, which is meant to only output files insideresources/.The path and root are now resolved before comparing, and the check requires either an exact match or the root followed by a
/. A..that climbs above the filesystem root returnsfalseinstead of throwing.Side effect:
getFiles()usesisWithinRoot()to decide between relative and absolute output paths, sogetFiles('../outside')now returns absolute paths instead of../-relative ones.