Skip to content

Add findAndRerank rerankCandidateLimit option - #2676

Open
Hazel-Datastax wants to merge 9 commits into
mainfrom
hazel/farr-rerank-candidate-limit
Open

Hazel-Datastax wants to merge 9 commits into
mainfrom
hazel/farr-rerank-candidate-limit

Conversation

@Hazel-Datastax

@Hazel-Datastax Hazel-Datastax commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:
This PR adds the contract for the new findAndRerank option rerankCandidateLimit. The option sets how many documents the command reads for a single leg sort. This PR only reads and checks the option.

Which issue(s) this PR fixes:
Part of #2601

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@github-actions

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 56.74%
This PR 57.11%
Delta 🟢 +0.37%
✅ Coverage improved!

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 57.11% 🍏
Files changed 100% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankPlanner.java 98.99% 🍏
FindAndRerankCommand.java 86.55% 🍏

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

📉 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 72.98%
This PR 72.72%
Delta 🔴 -0.26%
⚠️ Coverage decreased

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 72.72% -0.08% 🍏
Files changed 24.79% ❌

File Coverage
RequestException.java 100% 🍏
FindAndRerankCommand.java 82.06% 🍏
FindAndRerankPlanner.java 77.1% -14.81% ❌

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.13%
This PR 74.21%
Delta 🟢 +0.08%
✅ Coverage improved!

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.21% 🍏
Files changed 100% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankPlanner.java 98.32% 🍏
FindAndRerankCommand.java 82.96% 🍏

@Hazel-Datastax Hazel-Datastax changed the title Update findAndRerank limit contract Add findAndRerank rerankCandidateLimit option Nov 13, 2026
Comment on lines +12 to +18
interface RerankCandidateLimits {
// TODO: the design doc says "an integer greater than 1", that's different from
// HybridSearchLimits
int MIN = 2;
// TODO: the design doc says "The maximum value and the default value are TBC"
int DEFAULT = 50;
int MAX = 100;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the default value

@Hazel-Datastax
Hazel-Datastax marked this pull request as ready for review November 13, 2026 01:41
@Hazel-Datastax
Hazel-Datastax requested a review from a team as a code owner November 13, 2026 01:41
Base automatically changed from hazel/farr-sort-typed-legs to main November 14, 2026 00:34
@Hazel-Datastax
Hazel-Datastax force-pushed the hazel/farr-rerank-candidate-limit branch from 392610f to 64ca7e2 Compare November 14, 2026 00:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant