Skip to content

fix: Keep the "none" version label on unversioned role-group resources - #966

Merged
siegfriedweber merged 1 commit into
mainfrom
fix/unversioned-resources-labels
Oct 29, 2026
Merged

siegfriedweber merged 1 commit into
mainfrom
fix/unversioned-resources-labels

Conversation

@siegfriedweber

@siegfriedweber siegfriedweber commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Description

Keep the "none" version label on unversioned role-group resources

The listener PVC template in the StatefulSet lost its app.kubernetes.io/version: none label when the label construction moved to label::recommended_labels_for_unversioned_role_group_resources, which omits the label entirely. Since volumeClaimTemplates are immutable, the API server rejects the update of any StatefulSet deployed by an earlier operator version, leaving those role groups unreconcilable.

Build the labels with label::recommended_labels_for_role_group_resources instead and pass a UNVERSIONED_PRODUCT_VERSION placeholder, restoring the labels written up to 26.7.

Part of stackabletech/internal-issues#192

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Helm chart can be installed and deployed operator works
  • Integration tests passed:
    • --- PASS: kuttl/harness/smoke_trino-483_hive-4.2.1_opa-latest-1.20.2_hdfs-3.5.0_zookeeper-3.9.6_openshift-false (569.93s)
      
    • Upgrade from SDP 26.7 to trino=0.0.0-pr966 tested

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Oct 28, 2026
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Oct 28, 2026
@siegfriedweber
siegfriedweber marked this pull request as ready for review October 28, 2026 19:22

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber
siegfriedweber added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 38cb06f Oct 29, 2026
13 checks passed
@siegfriedweber
siegfriedweber deleted the fix/unversioned-resources-labels branch October 29, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants