Repository navigation
fix: Keep the "none" version label on unversioned role-group resources - #966
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep the "none" version label on unversioned role-group resources
The listener PVC template in the StatefulSet lost its
app.kubernetes.io/version: nonelabel when the label construction moved tolabel::recommended_labels_for_unversioned_role_group_resources, which omits the label entirely. SincevolumeClaimTemplatesare immutable, the API server rejects the update of any StatefulSet deployed by an earlier operator version, leaving those role groups unreconcilable.Build the labels with
label::recommended_labels_for_role_group_resourcesinstead and pass aUNVERSIONED_PRODUCT_VERSIONplaceholder, restoring the labels written up to 26.7.Part of stackabletech/internal-issues#192
Definition of Done Checklist
Author
trino=0.0.0-pr966testedReviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker