Skip to content

feat(versioned): Add support for the printcolumn argument - #1318

Merged
sbernauer merged 4 commits into
mainfrom
feat/versioned-printcolumn
Oct 29, 2026
Merged

sbernauer merged 4 commits into
mainfrom
feat/versioned-printcolumn

Conversation

@sbernauer

Copy link
Copy Markdown
Member

The printcolumn arguments are passed through unchanged to the generated #[kube(...)] attribute, so kube-derive does the parsing and validation. This keeps us in sync with upstream without mirroring its PrintColumn struct, and also supports the legacy JSON string syntax.

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

The printcolumn arguments are passed through unchanged to the generated
`#[kube(...)]` attribute, so kube-derive does the parsing and validation.
This keeps us in sync with upstream without mirroring its PrintColumn
struct, and also supports the legacy JSON string syntax.
@sbernauer
sbernauer requested a review from Techassi October 29, 2026 07:37
@sbernauer
sbernauer added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit a66da25 Oct 29, 2026
5 checks passed
@sbernauer
sbernauer deleted the feat/versioned-printcolumn branch October 29, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants