Repository navigation
feat(versioned): Add support for the printcolumn argument - #1318
Merged
Merged
Conversation
The printcolumn arguments are passed through unchanged to the generated `#[kube(...)]` attribute, so kube-derive does the parsing and validation. This keeps us in sync with upstream without mirroring its PrintColumn struct, and also supports the legacy JSON string syntax.
Techassi
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The printcolumn arguments are passed through unchanged to the generated
#[kube(...)]attribute, so kube-derive does the parsing and validation. This keeps us in sync with upstream without mirroring its PrintColumn struct, and also supports the legacy JSON string syntax.Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance