Repository navigation
Conversation
Maleware
changed the title
…kabletech/operator-rs into spike/containerdebug-switch
…kabletech/operator-rs into spike/containerdebug-switch
20 tasks
Maleware
marked this pull request as ready for review
October 29, 2026 12:37
Maleware
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
sbernauer
requested changes
Oct 29, 2026
| description = "Configures the `containerdebug` tool, which periodically logs information about the container environment. Learn more in the [container environment documentation](DOCS_BASE_URL_PLACEHOLDER/concepts/observability/containerdebug)." | ||
| ) | ||
| )] | ||
| pub struct ContainerDebugConfig { |
Member
There was a problem hiding this comment.
😢
Suggested change
| pub struct ContainerDebugConfig { | |
| pub struct ContainerdebugConfig { |
| /// Unlike the user-facing configuration, this cannot carry an interval while `containerdebug` is | ||
| /// disabled, nor an interval of zero. | ||
| #[derive(Clone, Debug, Eq, PartialEq)] | ||
| pub enum ValidatedContainerDebugConfig { |
Member
There was a problem hiding this comment.
😢
Suggested change
| pub enum ValidatedContainerDebugConfig { | |
| pub enum ValidatedContainerdebugConfig { |
| description = "Configures the `containerdebug` tool, which periodically logs information about the container environment. Learn more in the [container environment documentation](DOCS_BASE_URL_PLACEHOLDER/concepts/observability/containerdebug)." | ||
| ) | ||
| )] | ||
| pub struct ContainerDebugConfig { |
Member
There was a problem hiding this comment.
Please add this to the CRD preview:
diff --git a/crates/xtask/src/crd/dummy.rs b/crates/xtask/src/crd/dummy.rs
index 67cbbfe1..839ef101 100644
--- a/crates/xtask/src/crd/dummy.rs
+++ b/crates/xtask/src/crd/dummy.rs
@@ -117,7 +117,7 @@ pub mod versioned {
>,
}
- #[derive(Debug, Default, PartialEq, Fragment, JsonSchema)]
+ #[derive(Debug, PartialEq, Fragment, JsonSchema)]
#[fragment_attrs(
derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize, JsonSchema),
schemars(crate = "stackable_operator::schemars"),
@@ -130,6 +130,9 @@ pub mod versioned {
#[fragment_attrs(serde(default))]
pub logging: stackable_operator::product_logging::spec::Logging<Container>,
+
+ #[fragment_attrs(serde(default))]
+ pub containerdebug: stackable_operator::crd::containerdebug::v1alpha1::ContainerDebugConfig,
}
#[derive(Debug, Default, PartialEq, Fragment, JsonSchema)]|
|
||
| ### Added | ||
|
|
||
| - Add `crd::containerdebug.rs` module with versioned `ContainerDebugConfig` CRD ([#1308]) |
Member
There was a problem hiding this comment.
Suggested change
| - Add `crd::containerdebug.rs` module with versioned `ContainerDebugConfig` CRD ([#1308]) | |
| - Add `crd::containerdebug.rs` module with the `ContainerdebugConfig` CRD struct as well as helper functions on `ValidatedContainerdebugConfig` ([#1308]) |
Comment on lines
+47
to
+49
| schemars( | ||
| description = "Configures the `containerdebug` tool, which periodically logs information about the container environment. Learn more in the [container environment documentation](DOCS_BASE_URL_PLACEHOLDER/concepts/observability/containerdebug)." | ||
| ) |
Member
There was a problem hiding this comment.
Why duplicate it? ;)
Suggested change
| schemars( | |
| description = "Configures the `containerdebug` tool, which periodically logs information about the container environment. Learn more in the [container environment documentation](DOCS_BASE_URL_PLACEHOLDER/concepts/observability/containerdebug)." | |
| ) |
Member
|
@Maleware PR title pls :P |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Core of stackabletech/issues#884
Trino-operator spike
Definition of Done Checklist
Author
Reviewer
Acceptance