Repository navigation
Iceberg Rest Catalog Proxy support - #1729
Open
philippmats wants to merge 2 commits into
Open
philippmats wants to merge 2 commits into
philippmats wants to merge 2 commits into
Conversation
|
|
philippmats
force-pushed
the
feat/iceberg-proxy
branch
from
October 29, 2026 12:33
23bd68d to
f303e33
Compare
The Iceberg REST client (HTTPClient) already supports proxy settings via rest.client.proxy.hostname, .port, .username and .password, but Trino's REST catalog has no way to set them. Add iceberg.rest-catalog.http-proxy, .http-proxy.username and .http-proxy.password and pass them through to those client properties. Nothing changes unless the new options are set. Signed-off-by: Schoder Philipp (BD/DPA-BDP3) <Philipp.Schoder@de.bosch.com>
Signed-off-by: Schoder Philipp (BD/DPA-BDP3) <Philipp.Schoder@de.bosch.com>
philippmats
force-pushed
the
feat/iceberg-proxy
branch
from
October 29, 2026 12:39
f303e33 to
36ff135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a patch for Trino 481 that exposes HTTP proxy settings for the Iceberg REST catalog.
The Iceberg REST client ( HTTPClient ) already supports rest.client.proxy.hostname , .port , .username and .password , but Trino's REST catalog had no way to set them. The patch adds these catalog properties and passes them through to the client properties:
• iceberg.rest-catalog.http-proxy
• iceberg.rest-catalog.http-proxy.username
• iceberg.rest-catalog.http-proxy.password
Nothing changes unless the new options are set.
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.