Repository navigation
Validate Trino, auth and query configuration - #431
Draft
Bohreromir wants to merge 3 commits into
Draft
Bohreromir wants to merge 3 commits into
Bohreromir wants to merge 3 commits into
Conversation
Validates an http or https URL from an environment variable, treating a blank value as unset. Used by the Trino and OIDC settings in the following commits (#402).
STACKABLE_COCKPIT_TRINO_AUTH_TYPE, _TRINO_TLS_INSECURE, _TRINO_USER_IMPERSONATION, _QUERY_TTL and the Trino URLs fell back to defaults on invalid input, so a typo could silently disable TLS verification or impersonation. They are now parsed once at startup, and invalid values stop the server with an error naming each variable.
OIDC was silently disabled when only some of STACKABLE_COCKPIT_OIDC_DISCOVERY_URL, _CLIENT_ID and _CLIENT_SECRET were set. Setting only some of them now stops the server at startup, and the discovery URL must be an http or https URL.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #402
Docs
Release note
Checklist
Author
Reviewer
Acceptance