Repository navigation
env configured global bookmarks - #416
Open
Bohreromir wants to merge 7 commits into
Open
Bohreromir wants to merge 7 commits into
Bohreromir wants to merge 7 commits into
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bohreromir
force-pushed
the
feat-277-global-bookmarks
branch
from
October 27, 2026 15:48
cd1d7c2 to
a627bf7
Compare
Bohreromir
force-pushed
the
feat-277-global-bookmarks
branch
from
October 29, 2026 14:00
8018612 to
4365e47
Compare
…277) Administrators can configure read-only bookmarks for every user as a JSON array, also via the Helm chart (features.bookmarks.global). They are shown before the user's own bookmarks on the dashboard and in the sidebar, also without a signed-in user. Invalid configuration stops the server at startup.
features.bookmarks.global must be a YAML list. A JSON string, e.g. copied from the README, was encoded again and stopped the application at startup; Helm now fails at render time with a clear message instead.
The sidebar and the dashboard both list global bookmarks first via bookmarksInDisplayOrder. The GlobalBookmark alias is gone in favour of BookmarkLink.
Global bookmarks are configuration, not a feature toggle. They are parsed with parseEnv like the storage config, via a new envJson helper, and the module is imported for its side effect at startup. In the Helm chart, features.bookmarks.global moves to bookmarks.global, as features only holds toggles.
The pinned global bookmark from .env.test always shows Favourites, so the test passed even if the user's own pins stopped reaching the sidebar.
Bohreromir
force-pushed
the
feat-277-global-bookmarks
branch
from
October 29, 2026 14:40
d523928 to
63ff789
Compare
Bohreromir
marked this pull request as ready for review
October 29, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables Admins to set global Bookmarks for users via env variables
Docs
Release note
Checklist
Author
Reviewer
Acceptance