Repository navigation
Update to node 24.22.1 as well as bump the deps - #410
Open
Bohreromir wants to merge 15 commits into
Open
Bohreromir wants to merge 15 commits into
Bohreromir wants to merge 15 commits into
Conversation
Node.js 24.22.1 fixes the Brotli decoder buffer overflow (Brotli 1.0.3-1.2.0). Node's fetch decodes Content-Encoding: br responses from upstream services automatically. Bump dependencies to the latest versions within their semver ranges. Held back: - better-auth / @better-auth/drizzle-adapter on ~1.6.33: 1.7.0 drops genericOAuthClient from better-auth/client/plugins - tar-stream on 3.2.0: 3.2.1+ ships its own typings that conflict with @types/tar-stream and archive.ts Unpin @smithy/node-http-handler so it dedupes with the AWS SDK's copy.
Only breaking change splits audioWorklet globals out of browser; not used here.
Requires Prettier >= 3.7 (we have 3.9). No formatting changes.
9.0 drops Node 20 and replaces Express with plain Node HTTP handlers. The E2E mock only reads req.headers, which is unchanged.
TypeScript 7 is not an option yet: it ships no compiler API, and svelte-check, svelte2tsx, typescript-eslint and SvelteKit 2 all cap their peer range at 6.
3.2.1 ships its own typings, so drop @types/tar-stream and adapt archive.ts: Header instead of Headers, the entry stream type from ExtractEvents, inferred entry handler parameters, and an explicit Buffer cast for streamx data events. No runtime changes between 3.2.0 and 3.2.2.
0.56 reorganised the package exports, so the deep esm/ imports no longer resolve. Switch the editor worker and German NLS bundle to the public export paths; the NLS bundle now ships types, so drop the ts-expect-error. Monaco 0.57 pins DOMPurify to 3.4.15. Raise the override to ^3.4.17 for the latest sanitisation fixes and correct the stale note.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
# Conflicts: # package-lock.json # package.json
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
reviewed
Oct 28, 2026
better-auth 1.7 turns the generic OAuth plugin into a social provider:
- sign in via signIn.social({ provider }) instead of signIn.oauth2
- genericOAuthClient() no longer exists
- profile claims are typed unknown, so narrow them before mapping
The OAuth callback path moves from /api/auth/oauth2/callback/oidc to
/api/auth/callback/oidc. Deployments whose IdP has the exact old
redirect URI registered must update it.
Bump within existing ranges: - @aws-sdk/client-s3, @aws-sdk/lib-storage 3.1152.0 -> 3.1155.0 - typescript-eslint 8.71.2 -> 8.72.0 - @inlang/paraglide-js 2.29.0 -> 2.29.1 - knip 6.42.0 -> 6.42.1 - eslint-plugin-better-tailwindcss 4.9.1 -> 4.10.0 - @iconify-json/vscode-icons 1.2.91 -> 1.2.92 Also apply npm audit fix for fast-uri 3.1.8 -> 3.1.9.
dervoeti
previously approved these changes
Oct 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 29, 2026
better-auth 1.7 routes generic OAuth callbacks through the shared /callback/:id endpoint, so the trinoUser write guard from #397 rejected every OIDC sign-in. Take the path from the callbackOAuth endpoint.
dervoeti
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to node 24.22.1 as well as bump the deps
Docs
Release note
Checklist
Author
Reviewer
Acceptance