Skip to content

fix(parser): disable PLY table writing to support read-only filesystems (#838) #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShivanshhhG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(parser): disable PLY table writing to support read-only filesystems (#838) #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/spdx_tools/spdx/parser/tagvalue/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ def __init__(self, **kwargs):
self.elements_built = dict()
self.lex = SPDXLexer()
self.lex.build(reflags=re.UNICODE)
kwargs.setdefault("write_tables", False)
kwargs.setdefault("debug", False)
self.yacc = yacc.yacc(module=self, **kwargs)

@grammar_rule("start : start attrib ")
Expand Down
17 changes: 17 additions & 0 deletions tests/spdx/parser/tagvalue/test_tag_value_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,20 @@ def test_parse_none_or_no_assertion_as_text():
assert package.summary == "NONE"
assert package.license_concluded == SpdxNone()
assert package.license_declared == SpdxNoAssertion()


def test_parser_init_does_not_write_tables(monkeypatch):
import builtins

orig_open = builtins.open

def mock_open(file, *args, **kwargs):
mode = args[0] if args else kwargs.get("mode", "r")
if str(file).endswith(("parsetab.py", "parser.out")) and any(m in mode for m in ("w", "a", "+")):
raise OSError(30, "Read-only file system")
return orig_open(file, *args, **kwargs)

monkeypatch.setattr(builtins, "open", mock_open)
parser = Parser()
assert parser is not None