Repository navigation
ci: PR checks to build Docker images and check npm package - #1398
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
Dockerfile, Dockerfile.release, docker/** and npm-distribution/** had no pre-merge check: goreleaser.yml and docker.yml only run on release tags, and renovate automerges on green CI. Two path-filtered workflows now build every shipped image (with the same static linux binary goreleaser feeds to Dockerfile.release) and run npm ci + npm pack on the npm package. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a1a37e-8603-775d-bc85-c5677817f7a8
marcleblanc2
enabled stacked auto-merge (squash)
November 4, 2026 00:25
marcleblanc2
changed the title
marcleblanc2
disabled stacked auto-merge
November 4, 2026 00:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
goreleaser.ymlanddocker.ymlonly run on release tags, renovate automerges on green CI, so a bad digest bump or a human-made bug could land and only show a failure during a releaseSolution
Adding 2 PR checks:
Docker check (
Dockerfile*,docker/**): builds all three images and smoke-runs eachnpm check (
npm-distribution/**):npm ci,require("tar"),npm pack --dry-runNeither runs on Go-only commits. No new third-party actions.
Not a duplicate:
docker.ymlcan only build-and-push (needs Docker Hub secrets), and nothing buildsDockerfile.releasebefore a tagTest plan
Both workflows ran green on this branch