Repository navigation
deps: Fix 20 Dependabot alerts (next, sharp, mermaid 12, transitive refresh) - #2109
Open
marcleblanc2 wants to merge 3 commits into
Open
marcleblanc2 wants to merge 3 commits into
marcleblanc2 wants to merge 3 commits into
Conversation
Closes Dependabot alerts #304, #308, #309, #310, #311, #319, #320 (next) and #318 (sharp). eslint-config-next moves with next. The critical one, #304 (RCE in next/og ImageResponse), is not exploitable here: src/app/api/og/[...path]/route.tsx is force-static with dynamicParams = false, so the SVG only ever sees page titles from our MDX at build time. Amp-Thread-ID: https://ampcode.com/threads/T-01a17ac5-7379-71a7-997b-fc6a725d4672 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This comment has been minimized.
This comment has been minimized.
…ot alerts Closes the remaining 12 fixable alerts: - mermaid 11 -> 12 brings katex 0.18 and dompurify 3.4.17 within its own declared ranges (#315, #316, #307). Mermaid.tsx pins layout: dagre and look: classic so diagrams render as they did under mermaid 11. - pnpm update --depth 20 brace-expansion source-map-js @grpc/grpc-js dompurify: the parents already allowed the patched versions, the lockfile was stale (#303, #302, #314, #306, #305). - pnpm.overrides for toml (#282, #281) and uuid (#194): their parents under contentlayer2 pin old majors, and contentlayer2 has no newer release. - esbuild as a devDependency (#27): it is only a peer of contentlayer2 and mdx-bundler, which overrides do not reach. Amp-Thread-ID: https://ampcode.com/threads/T-01a17ac5-7379-71a7-997b-fc6a725d4672 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a17ac5-7379-71a7-997b-fc6a725d4672 Co-authored-by: Amp <amp@ampcode.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes 20 of the 24 open Dependabot alerts.
next^16.3.5 → ^16.3.8 (resolves to 16.4.3),eslint-config-nextto match,sharp^0.35.4 → ^0.35.5mermaid^11.16 → ^12.2, which bringskatex0.18 anddompurify3.4.17 within its own declared ranges.Mermaid.tsxpinslayout: dagreandlook: classicso diagrams render as they did under mermaid 11 (12 defaults to ELK layout and the "neo" look).pnpm update --depth 20 brace-expansion source-map-js @grpc/grpc-js dompurify: the parents already allowed the patched versions, the lockfile was just stale.pnpm.overridesfortomlanduuid: their parents undercontentlayer2pin old majors, andcontentlayer2has no newer release.tomlis only used for+++TOML frontmatter, which no page has.esbuild^0.25 as a devDependency: it is only a peer ofcontentlayer2andmdx-bundler, which overrides do not reach.#304 (RCE in
next/ogImageResponse) is not exploitable here:src/app/api/og/[...path]/route.tsxisforce-staticwithdynamicParams = false, soImageResponseonly ever sees page titles from our own MDX at build time. #308 (SSRF in image optimization) does not apply either;next.config.jshas noimagesconfig.Not in this PR
@opentelemetry/propagator-jaeger,@opentelemetry/core): the fix is OTel SDK 2.x, andcontentlayer2→@effect-ts/otelpins 1.x with a different@opentelemetry/apipeer. That tracing only runs insidecontentlayer2 buildand never reads a request header. Dismiss as "vulnerable code is not actually used".sprintf-js), #312 (braces): withdrawn advisories with no patched version. Dismiss.Test plan
pnpm install: no new peer warnings (thelucide-react/ React 19 one is pre-existing);@opentelemetry/apistays at 1.9.0npx tsc --noEmitclean against mermaid 12pnpm run build: 1494 static pages, OG images render as 1200×630 PNGspnpm run lint: 0 errors, same 8 pre-existing warnings asmainpnpm start, loaded/admin/architectureand/self-hosted/sourcegraph-nginx-mermaidin headless Chrome: diagrams render with the same dagre layout and classic look as mermaid 11