Skip to content

fix: implement pause state and abqsn refactor - #1436

Merged
mdydek merged 2 commits into
mainfrom
fix/scheduled-source-paused-state
Nov 13, 2026
Merged

mdydek merged 2 commits into
mainfrom
fix/scheduled-source-paused-state

Conversation

@mdydek

@mdydek mdydek commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Closes #1434

⚠️ Breaking changes ⚠️

Introduced changes

  • added paused state in AudioScheduledSourceNode because there were some nodes that try to "mimic" this state by using some variables and then some function reusal was very inconvenient, because they assumed one shot of node, whereas there are some multishot nodes, such as: AudioBufferQueueSourceNode, AudioFileSourceNode
  • fixed the issue described in fix: resume a paused AudioBufferQueueSourceNode #1434, however fix proposed there had one problem (stop immediately when the node was stopped)
  • unify the state handling in AudioBufferQueueSourceNode and remove exporting private state type

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@mdydek mdydek added the fix Code changes specifically addressing and resolving a bug label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

WPT non-regression comparison

PASS — no regressions · 0 improved section(s) · overall 3430 → 3430 (0)

Unchanged sections (28)
Spec section Base pass Head pass Delta
Processing model 1 1 0
Other 56 56 0
AnalyserNode 138 138 0
AudioBuffer 142 142 0
AudioBufferSourceNode 220 220 0
AudioContext 58 58 0
AudioNode 261 261 0
AudioParam 680 680 0
BiquadFilterNode 275 275 0
ChannelMergerNode 30 30 0
ChannelSplitterNode 7 7 0
ConstantSourceNode 64 64 0
ConvolverNode 179 179 0
DelayNode 127 127 0
DestinationNode 0 0 0
DynamicsCompressorNode 4 4 0
GainNode 15 15 0
IIRFilterNode 87 87 0
MediaElementAudioSourceNode 0 0 0
MediaStreamAudioDestinationNode 1 1 0
MediaStreamAudioSourceNode 0 0 0
OfflineAudioContext 35 35 0
OscillatorNode 104 104 0
PannerNode 727 727 0
PeriodicWave 33 33 0
ScriptProcessorNode 0 0 0
StereoPannerNode 104 104 0
WaveShaperNode 82 82 0

Baseline: b3d198bb18013ff3188ba90fdb6385339d2e3d95 · Candidate: c36aa95e34a92ddf395f6093d3483fc2b5d77de5

Workflow run · this comment is updated on every push.

@mdydek
mdydek merged commit fb1b444 into main Nov 13, 2026
15 checks passed
@mdydek
mdydek deleted the fix/scheduled-source-paused-state branch November 13, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Code changes specifically addressing and resolving a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants