Repository navigation
fix: implement pause state and abqsn refactor - #1436
Merged
Merged
Conversation
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 3430 → 3430 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
maciejmakowski2003
requested changes
Nov 12, 2026
maciejmakowski2003
approved these changes
Nov 12, 2026
closetcaiman
approved these changes
Nov 13, 2026
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1434
Introduced changes
AudioScheduledSourceNodebecause there were some nodes that try to "mimic" this state by using some variables and then some function reusal was very inconvenient, because they assumed one shot of node, whereas there are some multishot nodes, such as:AudioBufferQueueSourceNode,AudioFileSourceNodeChecklist