Repository navigation
ci: open a pull request when the agent skills update - #320
Conversation
WilliamBergamin
left a comment
There was a problem hiding this comment.
🙏 Thanks @mwbrooks, the find loop picks up all three sample folders without naming them, so one copy of the workflow fits this repo as-is.
Left one optional comment on pinning skills, nothing blocking 💯
| - name: Update the skills in each skills-lock.json | ||
| run: | | ||
| while IFS= read -r lock; do | ||
| (cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes) |
There was a problem hiding this comment.
📦 suggestion (non-blocking): skills@1 floats to each new 1.x release, and anything it writes to .git/hooks or $GITHUB_PATH runs in the next step with GH_TOKEN set. Could we pin an exact version, like skills@1.9.0, or commit with git -c core.hooksPath=/dev/null commit?
There was a problem hiding this comment.
note: Keeping skills@1 for now, per our DM. The token stays off the npx step, and a pin would mostly add version bumps to chase across 49 samples.
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false |
There was a problem hiding this comment.
💯 praise: persist-credentials: false with GH_TOKEN only on the last step keeps the npx run away from the token, and the explicit pathspecs leave the stray .grok/ and .kiro/ folders out.
|
Thanks @zimeg for the review, and @WilliamBergamin for the careful look at the token and the |
Summary
This pull request keeps the pre-installed agent skills current for developers who build from this sample, so their coding agent follows the latest Slack guidance without anyone running
npx skills updateby hand.npx skills@1 update --project --yesin each folder with askills-lock.json(3 in this repository) and opens onechore: update agent skillspull request when the skills change..agents/skills,.claude/skills, andskills-lock.json, becauseskillsalso writes.grok/and.kiro/folders on update.Testing
Notes
mainofslackapi/slack-skills-plugin, the same asnpx skills update.