Skip to content

feat(methods): add apps.icon.set method example - #134

Merged
zimeg merged 3 commits into
mainfrom
zimeg-feat-apps-icon-examples-set
Nov 20, 2026
Merged

zimeg merged 3 commits into
mainfrom
zimeg-feat-apps-icon-examples-set

Conversation

@zimeg

@zimeg zimeg commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds a method example for apps.icon.set in methods/src/main/java/apps/icon/AppsIconSet.java, and lists it in methods/README.md.

  • The arguments match the siblings in bolt-js-examples and bolt-python-examples, with the example values from the reference page.
  • Adds apps/icon/manifest.json with no scopes. The method needs app_configurations:write, which an app manifest can't request (apps.manifest.validate returns illegal_user_scopes), so the token comes from the app's configuration.

This is part 1 of 1 in the apps.icon stack, which is based on main and matches slackapi/java-slack-sdk#1707. This pull request is in batch B7 app settings.

  1. feat(methods): add apps.icon.set method example #134 apps.icon.set 👈 this pull request

Dependency

This depends on slackapi/java-slack-sdk#1707, which adds appsIconSet to slack-api-client. It shipped in slack-api-client 1.56.0, which methods/pom.xml now pins.

Testing

With slackapi/java-slack-sdk#1707 installed locally (./scripts/install_local.sh) and the pin pointed at that snapshot:

  1. cd methods and export SLACK_TOKEN=... with a user token with app_configurations:write.
  2. mvn compile exec:java -Dexec.mainClass=apps.icon.AppsIconSet and check the response. Replace the placeholder values with real ones to see ok.

Every example compiles against the SDK changes. The call matches the remote test in slackapi/java-slack-sdk#1707, which checks it against the live API.

🤖 Generated with Claude Code

@zimeg
zimeg changed the base branch from zimeg-feat-admin-conversations-examples-unlink-objects to main November 18, 2026 06:17
@zimeg
zimeg force-pushed the zimeg-feat-apps-icon-examples-set branch from e9f1646 to 3723493 Compare November 18, 2026 06:17
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg marked this pull request as ready for review November 20, 2026 10:10
@zimeg
zimeg requested a review from a team as a code owner November 20, 2026 10:10

@cchensh cchensh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The call matches the released SDK (method, argument names and types), the structure matches the sibling examples, and CI is green.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

# Conflicts:
#	methods/README.md
@zimeg

zimeg commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind review @cchensh! Happy to have the app settings methods in the java examples ☕

@zimeg
zimeg merged commit 722ac8b into main Nov 20, 2026
4 checks passed
@zimeg
zimeg deleted the zimeg-feat-apps-icon-examples-set branch November 20, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants