Skip to content

fix(docs): keep search responsive and contain sidebar scrolling - #9786

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/docs-search-latency
Nov 7, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/docs-search-latency

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Return local docs search matches immediately; use optional hybrid search only for local misses, with a one-second budget that preserves completed results.
  • Reduce search startup work with a compact citation catalog and give stalled browser requests a five-second timeout with retry.
  • Prevent horizontal scrolling in desktop and mobile sidebars while preserving vertical scrolling and keyboard navigation.

Type of Change

  • Bug fix

Testing

Production docs build, full repository tests, lint, type-check, all 62 audits, and the block registry check. Real PostgreSQL (IPv4 and IPv6) and paused TCP/provider E2E checks cover local results, deadlines, concurrency limits, partial results, and recovery; negative controls fail when the corresponding fixes are removed, including observer cancellation before the independent request timeout. Production Chromium and WebKit navigation suites, responsive sidebar checks in both themes, documentation corpus/interface checks, and generator idempotence checks.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 7, 2026 9:51pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found.

Summary

The PR returns local docs matches immediately, limits optional hybrid search to one second, adds a five-second browser timeout, and prevents sideways sidebar scrolling.

  • Docs search returns local matches before optional database results arrive.
  • Search citations now come from a compact page catalog.
  • Stalled documentation searches now time out and offer a retry.
  • Docs sidebars stop scrolling sideways while keeping vertical scrolling.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Query[Docs search] --> Local[Search local index]
  Local --> Match{Local matches?}
  Match -->|Yes| Return[Return results]
  Match -->|No| Optional{Database configured and capacity available?}
  Optional -->|No| Empty[Return no matches]
  Optional -->|Yes| Hybrid[Run keyword and vector searches]
  Hybrid --> Budget[Finish or reach one-second deadline]
  Budget --> Partial[Return completed results]
Loading

Reviews (2) · Last reviewed commit: "fix(docs): strengthen search cancellatio..." · Reviewed by Greptile

Comment thread apps/docs/hooks/queries/search.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit ced5556 into staging Nov 7, 2026
52 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/docs-search-latency branch November 7, 2026 21:58

This branch was successfully deployed

1 active deployment
Preview — 1acb187a Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant