Skip to content

fix(org): drop leftovers of the reverted search history source removal - #9746

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/org-legacy-release-review
Nov 6, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/org-legacy-release-review

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • revert(org): hold the org view and People redesigns for #9687 #9740 deleted the search history sources route but left the code only it reached; restores those files to their main versions
  • Removes the unused useEffect, OAUTH_SEARCH_READ_SCOPE and oauthScopeSatisfies imports in hooks/queries/oauth-provider.ts
  • Removes the unused removeSearchHistorySourceContract and SearchHistoryResponse imports in hooks/queries/search-history.ts, and both now-dead exports from the search history contract
  • Removes the orphaned removeSearchHistorySource use case, its removeSource operation, the remove-source repository event and its integration test case

Type of Change

  • Bug fix

Testing

  • bun run type-check (apps/sim), biome on the changed files
  • scripts/check-unused-exports.ts, check:api-validation:strict
  • Deletion only; no new tests

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

#9740 deleted the search history sources route but kept the code that
only it reached: the remove-source use case, operation, repository event
and contract, plus unused imports in the oauth-provider and search-history
hooks. Restore those files to their main versions.
@vercel

vercel Bot commented Nov 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 6, 2026 7:37pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This cleanup appears safe to merge.

Summary

This PR removes code left behind after the search-history source-removal route was reverted.

  • Search history no longer offers a separate one-source removal operation.
  • The OAuth and history hooks keep working without unused declarations.

Reviews (1) · Last reviewed commit: "fix(org): drop leftovers of the reverted..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit d22623b into staging Nov 6, 2026
61 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/org-legacy-release-review branch November 6, 2026 19:39
waleedlatif1 added a commit that referenced this pull request Nov 6, 2026

This branch was previously deployed

1 inactive deployment
Preview — 5b7be7da Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant