Repository navigation
fix(assistant-actions): read a run that closes mid-review as nothing to review - #9721
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryReview reads now return an empty result when a run closes while the read waits.
Reviews (2) · Last reviewed commit: "fix(assistant-actions): return a fresh e..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireAssistantRunwaits on the chat row lock. A turn that closes in between makes the second step throwconflict, which is right for a decision or claim but wrong for a readWhy
The review query polls while a turn runs, so this race surfaces whenever a turn ends during a poll. It also fails the
e2e (org-redesign)health check, which treats any failed same-origin request as a failure, and that check gates staging deploys.Type of Change
Testing
tool-permissions.integration.tsholds the chat row lock while the run closes, waits until the read is blocked on it throughpg_blocking_pids, then commitsThis conversation is no longer accepting actions; the file passes 72/72 with the fixChecklist
test-auditauthoring gate)