Skip to content

fix(people): harden paused SCIM sync and directory inputs - #9670

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/people-release-review-9660
Nov 4, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/people-release-review-9660

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Pause SCIM directory sync when provisioning is disabled, preserve the published chart and sync history, and resume cleanly when provisioning returns. Exclude paused sources before scheduler limits and fence publication against concurrent source changes.
  • Keep SCIM activity telemetry from waiting behind publication locks, and scope pending-change markers to the correct organization.
  • Add a replay-safe concurrent scheduler index, validate People URL identifiers against shared API limits, and align audit mocks with sync actions. Keep the feature flag and hidden docs in place.

Type of Change

  • Bug fix

Testing

  • Full root bun run test, lint, workspace type-checks, 62 audits, test-type ratchet, migration and block-registry checks pass. All four ship generators produce no tracked drift; Drizzle reports no schema drift.
  • 49 real PostgreSQL People/SCIM integration checks, 32 SCIM HTTP checks (256 requests), and 20 People HTTP/browser checks (52 requests) pass. Final lifecycle tests also pass after fixture cleanup.
  • Guard-removal regressions fail as expected. Verified interrupted concurrent-index recovery and replay, paused chart retention, malformed links, and mouse/touch canvas controls.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 4, 2026 10:22am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 17 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Pauses People sync when SCIM provisioning is disabled while keeping the published chart and sync history.

  • People sync pauses when SCIM provisioning is disabled.
  • SCIM authentication skips activity writes when its connection is locked.
  • People links and API inputs reject malformed directory identifiers.
  • SCIM change markers get an index for scheduler scans.

No actionable issues were found. Tests were inspected but not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Manual request or scheduler] --> B{SCIM provisioning disabled?}
  B -->|Yes| C[Keep published chart and history]
  B -->|No| D[Claim sync run]
  D --> E[Lock profiles and sync row]
  E --> F[Lock connection and check status]
  F --> G{Still active?}
  G -->|No| H[Clear run without publishing]
  G -->|Yes| I[Stage, validate, and publish]
  J[Re-enable provisioning] --> K[Write pending-change marker]
  K --> A
Loading

Reviews (1) · Last reviewed commit: "fix(people): harden paused SCIM sync and..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 30dc79e into staging Nov 4, 2026
83 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/people-release-review-9660 branch November 4, 2026 18:13

This branch was successfully deployed

1 active deployment
Preview — 9b5e11b2 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant