Skip to content

fix(resume): carry the admitted resume run's ID on outer resume failure logs #9663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Nov 4, 2026
Merged

fix(resume): carry the admitted resume run's ID on outer resume failure logs #9663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/sim/lib/workflows/executor/resume-execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ export async function executeResumeWorkflow({
actorUserId: preprocessResult.actorUserId,
})

let admittedResumeExecutionId: string | undefined
try {
const enqueueResult = await PauseResumeManager.enqueueOrStartResume({
executionId,
Expand All @@ -252,6 +253,7 @@ export async function executeResumeWorkflow({
userId,
allowedPauseKinds: ['human'],
})
admittedResumeExecutionId = enqueueResult.resumeExecutionId

if (enqueueResult.status === 'queued') {
return {
Expand Down Expand Up @@ -441,7 +443,11 @@ export async function executeResumeWorkflow({
logFailureOnce(logger, 'Resume request failed', error, {
executionId,
metadata: () =>
projectResolvedSecretDiagnosticError(error, undefined, { workflowId, contextId }),
projectResolvedSecretDiagnosticError(error, undefined, {
workflowId,
contextId,
resumeExecutionId: admittedResumeExecutionId,
}),
})
if (statusCode !== undefined) {
throw new ResumeWorkflowExecutionError(statusCode, toError(error).message, statusCode < 500)
Expand Down
Loading