feat(video-generator): refresh native provider catalogs and request protocols by waleedlatif1 · Pull Request #9658 · simstudioai/sim

waleedlatif1 · 2026-11-04T02:56:44Z

Summary

Refresh the Video Generator with all 25 Runway video models plus Google Gemini Omni 1.1 Flash, Luma Ray 3.2, and current MiniMax H3/Hailuo models. Keep supported saved aliases and existing Runway, Luma, and MiniMax defaults.
Send each model to its documented API, validate supported settings before submitting a job, and use bounded, DNS-pinned output downloads.
Preserve saved setting IDs, Agent audio choices, boolean prompt optimization, default model metadata, and terminal failure handling. Honor published Runway, Ray 3.2, and MiniMax H3 prompt limits before submitting a job. Select the active conditional field definition during workflow state replacement, matching ordinary workflow edits. Keep the fal catalog and its request path intact; record the added client metadata modules in the bundle boundary baseline.
Stabilize test fixtures: read large Git messages from a file, and classify only the expected streamed 404 recovery on the two denied-chat E2E cases. Keep all browser error diagnostics and reject unmatched errors. Isolate extension capture scenarios in fresh panels so rejected-send recovery cannot leak into the next scenario.

Type of Change

Feature and bug fix

Testing

Runway live OpenAPI: 25 models, 49 text/image variants, 1,325 requests through block and tool mapping, including every published maximum prompt length and rejection above that limit.
MiniMax and legacy Luma published OpenAPI: 694 request combinations; Google Omni and Ray 3.2 checked against official API documentation and native submit/poll/result regressions. No paid inference jobs were submitted.
Existing fal catalog: 112 endpoints and 1,808 schema request variants still pass.
Regression checks cover serialization of saved settings with explicit and default models, provider protocols, state replacement, legacy metadata, MiniMax failure/Pro handling, empty and malformed camera controls, cancellation, and output size limits.
Replayed the recorded denied-page browser diagnostics through the E2E assertion, with five negative controls for unexpected errors; all seven checks pass.
Root tests, all workspace type checks, the separate test-type ratchet, lint, all audits, block registry and generated artifact checks pass.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…rotocols

vercel · 2026-11-04T02:56:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 4, 2026 4:10am UTC

cubic-dev-ai

All reported issues were addressed across 18 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-11-04T03:01:25Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Refreshes native video models and routes requests through provider-specific APIs.

The Video Generator offers current models with settings tailored to each one.
Direct video models use their own request formats and return handling.
Workflow replacement validates the active conditional field definition.
Test scripts isolate browser scenarios and keep expected errors distinct.

All four earlier, unnumbered findings are addressed in the current code. No new actionable issues were found in the changes since the previous review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Workflow or Agent] --> B[Map selected model settings]
  B --> C{Provider}
  C -->|Native| D[Check settings and prompt]
  D --> E[Submit provider job]
  E --> F[Poll provider job]
  F --> G[Read bounded video output]
  C -->|Fal.ai| H[Existing Fal.ai path]
  G --> I[Store video and return metadata]
  H --> I

_{Reviews (4) · Last reviewed commit: "fix(video-generator): retain empty contr..." · Reviewed by Greptile}

waleedlatif1 · 2026-11-04T03:32:15Z

@greptile

waleedlatif1 · 2026-11-04T03:32:16Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T03:32:22Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 22 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T03:51:01Z

@greptile

waleedlatif1 · 2026-11-04T03:51:02Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T03:51:08Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 22 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T04:10:47Z

@greptile

waleedlatif1 · 2026-11-04T04:10:48Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T04:10:54Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 23 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

feat(video-generator): refresh native provider catalogs and request p…

9f13a2e

…rotocols

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/tools/video/veo.ts Resolved

Comment thread apps/sim/tools/video/runway.ts Resolved

Comment thread apps/sim/lib/internal/video/direct-request.ts Resolved

vercel Bot deployed to Preview November 4, 2026 03:01

View deployment

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/video_generator.ts Resolved

Comment thread apps/sim/lib/internal/video/client.ts Resolved

Comment thread apps/sim/lib/media/runway-video-models.json Resolved

fix(video-generator): preserve saved settings and fix CI

eb73cc8

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/video_generator.ts Resolved

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/video/direct-request.ts Resolved

fix(video-generator): preserve Agent audio and model prompt limits

f760903

vercel Bot temporarily deployed to Preview November 4, 2026 03:50 Inactive

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/video/direct-request.ts Resolved

Comment thread apps/sim/lib/internal/video/client.ts Resolved

fix(video-generator): retain empty controls and isolate CI scenarios

213f651

vercel Bot temporarily deployed to Preview November 4, 2026 04:10 Inactive

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

waleedlatif1 merged commit b5660ac into staging Nov 4, 2026
83 checks passed

waleedlatif1 deleted the codex/direct-video-catalogs branch November 4, 2026 04:14

This was referenced Nov 4, 2026

v0.9.43: Sim links from search and file shares, synced org chart, CLI recovery guidance, image and video catalog refresh #9660

Merged

fix(media): preserve video settings and Google URI delivery #9669

Merged

Conversation

waleedlatif1 commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Nov 4, 2026 •

edited

Loading

vercel Bot commented Nov 4, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Nov 4, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading