Skip to content

fix(workflows): keep the Run-button lint finding advisory and point at lint from apply warnings - #9645

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/lint-manual-run-followups
Nov 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/lint-manual-run-followups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Lint's manualRunIssue (what the editor's Run button would refuse) is now worded as advice, kept out of "Fix these before continuing". Agent and v2 runs never apply the Run button's checks: when a workflow has more than one trigger they require an explicit trigger. So a stray unconnected Start next to a connected webhook or schedule trigger used to read as a blocker, which pushed agents to wire the Start into the graph.
  • For an unconnected trigger, the advice names the block and gives both fixes: connect it, or delete it if the workflow starts from another trigger. It also says that runs which name their trigger are not affected.
  • Apply-operations warnings now carry a one-line pointer that counts the findings by category ("… The findings are in lint.") instead of a second full copy of the lint message. The full findings stay in lint. A caller that reads only warnings still learns that issues exist.
  • The formatter is refactored into one table-driven list of sections, which feeds both the full message (sim workflows lint) and the pointer.
  • The editor's Run button selection is unchanged: an unconnected Start still wins over a connected trigger, and that stays a separate UX decision.

Type of Change

  • Bug fix

Testing

  • lint.test.ts and apply-workflow-operations.test.ts: the new and updated cases failed on the pre-fix code. They pass now.
  • Ran the lib/workflows/editing, lib/mothership/agent-cli, lib/api/contracts/v2 and app/api/v2/workflows suites.
  • Ran bun run lint and check:openapi, and regenerated the OpenAPI, CLI and MCP artifacts. CI runs the full gate.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Building Building Preview Nov 3, 2026 11:34pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Keeps the editor’s Run-button advice separate from findings an agent should fix.

  • Lint separates Run-button advice from findings that need fixing.
  • Apply-operation warnings point to the full lint report.

Reviews (1) · Last reviewed commit: "fix(workflows): keep the Run-button lint..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit e5621b6 into staging Nov 3, 2026
63 of 64 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/lint-manual-run-followups branch November 3, 2026 23:39

This branch was successfully deployed

1 active deployment
Preview — 3ecef5c7 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant