Repository navigation
fix(workflows): keep the Run-button lint finding advisory and point at lint from apply warnings - #9645
Merged
Conversation
…t lint from apply warnings
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryKeeps the editor’s Run-button advice separate from findings an agent should fix.
Reviews (1) · Last reviewed commit: "fix(workflows): keep the Run-button lint..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manualRunIssue(what the editor's Run button would refuse) is now worded as advice, kept out of "Fix these before continuing". Agent and v2 runs never apply the Run button's checks: when a workflow has more than one trigger they require an explicit trigger. So a stray unconnected Start next to a connected webhook or schedule trigger used to read as a blocker, which pushed agents to wire the Start into the graph.warningsnow carry a one-line pointer that counts the findings by category ("… The findings are inlint.") instead of a second full copy of the lint message. The full findings stay inlint. A caller that reads onlywarningsstill learns that issues exist.sim workflows lint) and the pointer.Type of Change
Testing
lint.test.tsandapply-workflow-operations.test.ts: the new and updated cases failed on the pre-fix code. They pass now.lib/workflows/editing,lib/mothership/agent-cli,lib/api/contracts/v2andapp/api/v2/workflowssuites.bun run lintandcheck:openapi, and regenerated the OpenAPI, CLI and MCP artifacts. CI runs the full gate.Checklist
test-auditauthoring gate)