Skip to content

fix(ci): attribute pull requests against the tested target parent - #9644

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-attribution-ancestry-ready
Nov 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-attribution-ancestry-ready

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Fix unnecessary full CI on narrow PR updates after staging advances: the old event base can be disconnected in a shallow checkout even when its commit exists.
  • Attribute against the actual tested GitHub merge's target parent after verifying the merge ref, triggering SHA, and two-parent shape. Retain full fallback when attribution is uncertain.
  • Preserve manual-base and push behavior; planner/configuration changes, including this PR, still run full CI.

Type of Change

  • Bug fix

Testing

  • 62 real Git/Turbo cases, including shallow multi-commit PRs, upstream changes, and invalid checkout identities.
  • Regressions demonstrated red before implementation; ref, SHA, parent-shape, and parent-selection mutations independently go red.
  • Root bun run test, lint, type-check, all audits, artifact generators, block-registry check, and actionlint.
  • Cleanup and test-audit; no retries, timeout changes, or coverage reductions.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 3, 2026 11:30pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

PR checks now compare the tested GitHub merge with its first parent instead of relying on the event’s potentially stale base SHA.

  • Pull request CI scopes checks from the target parent in its tested merge.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Valid comparison SHA] --> B{Pull request?}
  B -->|Yes| C{Merge ref, SHA and parents match?}
  C -->|Yes| D[Use first parent]
  C -->|No| F[Run every check]
  B -->|No| E[Use existing merge-base logic]
  D --> G[Compare files and query affected tasks]
  E --> G
  G -->|Success| H[Run selected checks]
  G -->|Missing history or attribution error| F
Loading

Reviews (1) · Last reviewed commit: "fix(ci): attribute pull requests against..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 9e1f122 into staging Nov 3, 2026
80 of 81 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-attribution-ancestry-ready branch November 3, 2026 23:27

This branch was successfully deployed

1 active deployment
Preview — 11a68f28 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant