Repository navigation
feat(video): expand the fal text-to-video model catalog - #9640
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The changes appear safe to merge; no actionable new issue was established. SummaryExpands the fal Video Generator catalog while keeping saved model IDs working.
No actionable new issues were established in the changes since the previous review. Reviews (3) · Last reviewed commit: "fix(video): poll nested fal models throu..." · Reviewed by Greptile |
There was a problem hiding this comment.
1 issue found across 10 files
Confidence score: 3/5
- In
apps/sim/lib/internal/video/client.ts, a failed download or Stop can leave a Fal.ai charge without billing metadata. Reconcile the cost as soon as generation completes, independently of the download.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/internal/video/client.ts">
<violation number="1" location="apps/sim/lib/internal/video/client.ts:852">
P1: This downloads the completed Fal.ai media before reconciling hosted cost, so a download failure or Stop can leave a provider charge without billing metadata. Resolve the cost immediately after completion, independently of the caller abort signal, before downloading the media.
(Based on your team's feedback about completed Fal.ai cost reconciliation.)</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 11 files
Confidence score: 3/5
- In
apps/sim/lib/internal/video/client.ts, the fallback can return 405 for models with/text-to-videowhen convenience URLs are absent. Build the fallback from the owner/app segments instead.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/internal/video/client.ts">
<violation number="1" location="apps/sim/lib/internal/video/client.ts:784">
P2: The fallback uses the full model endpoint, but Fal request URLs use only the owner/app segments; models with `/text-to-video` can receive 405 responses when convenience URLs are absent. Build this fallback from `endpoint.split('/').slice(0, 2)` instead.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
Checklist