Repository navigation
fix(files): accept files/ VFS paths in v2 file download and sim files get - #9637
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; path downloads retain workspace access checks and final content checks. SummaryAdds
No actionable issues were found. Tests were not run during this review.
|
waleedlatif1
added a commit
that referenced
this pull request
Nov 4, 2026
…f a mocked route call (#9662) * test(files): prove files/ VFS path downloads over real HTTP instead of a mocked route call The v2 file download case added in #9637 passed the decoded path straight to the handler and asserted on the mocked use case, so it could not catch an encoded files/ path failing to reach the route or resolving to the wrong file. The file delivery e2e now uploads same-named files at the root and in a folder and downloads each by its %2F-encoded VFS path through the running app. * test(files): keep the HTTP check to the routing it proves
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim files get/GET /api/v2/files/[fileId]now accept thefiles/<folder>/<name>VFS path, same as describe/rename/delete (fix(files): accept files/ VFS paths in v2 file describe, rename and delete #9504, fix(files): resolve v2 file paths only on the v2 surface, through the canonical resolver #9531); a path used to fail with a bare "Invalid file id"v2FileIdOrPathParamsSchema, route and the in-process Chat download transport opt in withacceptVfsPath: true, so only the resolver's input-onlyvalidationanswers before authorization and every other unresolved path goes throughadmitUnresolvedPath--output-fileresult no longer echoes a path asid; regenerated CLI API, OpenAPI audit, and CLI docsType of Change
Testing
delivery.integration.ts(real Postgres + local storage), new checks:route.test.ts: GET with a path reaches the use case withacceptVfsPath: true— red without the route opt-inapp/api/v2/files/,file-provenance.test.ts,download-workspace-file.test.ts;bun run lint;check:api-validation:strict,check:cli-api,check:openapi,check:cli-docsChecklist
test-auditauthoring gate)