Skip to content

improvement(executor): make run-from-block refusals actionable - #9636

Merged
waleedlatif1 merged 3 commits into
stagingfrom
improvement/run-from-block-errors
Nov 3, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
improvement/run-from-block-errors

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • validateRunFromBlock now returns a structured refusal (block_not_found, inside_subflow, upstream_not_executed), carried on RunFromBlockValidationError; class, error codes and message prefixes the canvas matches on are unchanged
  • Executor messages name blocks instead of bare ids (Upstream dependency not executed: Fetch, Cannot run from block inside loop: Each row. Run the loop or the whole workflow instead.)
  • Copilot run_from_block / run_block rewrite the refusal for the agent from the loaded workflow state:
    • upstream not run: names both blocks and the source execution, points at run_workflow_until_block (stopAfterBlockId) or an executionId that ran the upstream block
    • inside loop/parallel: names the container, points at starting from it or run_workflow
    • unknown id: says it is not in the draft/deployed workflow and lists its blocks (first 20, then "and N more"); a known but disabled block says it is disabled
  • No behavior change: nothing extra runs, run_block still runs one approved block

Type of Change

  • Improvement

Testing

  • executor/utils/run-from-block.test.ts, executor/execution/executor.test.ts, lib/workflows/application/run-workflow-from-copilot.test.ts (59 passing); the 6 new/changed assertions fail on the pre-fix code
  • biome on changed files, check:comment-hygiene; type-check and remaining audits left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 3, 2026 9:15pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with no outstanding findings.

Summary

The PR gives refused block runs clearer messages and next steps.

  • Run-from-block refusals identify the block and the reason it cannot start.
  • Copilot explains how to recover from a refused block run.

Reviews (3) · Last reviewed commit: "chore(executor): type subflow configs in..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit f0c083c into staging Nov 3, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant