Repository navigation
improvement(chat): let Chat review organization access requests - #9610
Merged
Merged
Conversation
Organization admins can list, preview, approve and deny access requests from an organization conversation through the settings tool's new requests section. The admin list, preview and resolve operations now admit organization-delegated Copilot principals under the sim:settings audience; role, audit, outbox notice and fingerprint checks are unchanged. Request settings stay session-only.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Critical impact] The PR appears safe to merge. SummaryLets organization admins review access requests through Chat’s
No actionable new issues were found in the changes since the previous review.
|
The settings tool parses list input before calling the reader, so an omitted status reached it as undefined and listed every status. The list schema now defaults status to pending, matching get; explicit statuses still apply.
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settingstool's neworganization/requestssection (get,list,preview,approve,deny). No confirmation cardorganization_delegated,sim:settings,copilot), matching the other org settings sections. Minimum role stays admin; fingerprint checks, decided-notice events, audit and locking are unchanged because the same use cases runrequireAccessRequestPrincipalreplaces two private copies of the principal check;requireAllowedOrganizationPrincipalis extracted fromauthorizeOrganizationOperationwith identical behaviorType of Change
Testing
copilot-review.integration.ts(real Postgres, realsettingstool and chat context): a member's Chat is refused every op and nothing changes; an admin's Chat approves (grant applied, decided notice, audit shows Chat acting for the admin) and denies (reason stored, policy unchanged). Red before the change; red again when review's minimum role is lowered or the Chat policy is droppedee/access-requestsintegration files 40/40;settings,settings-management-boundary,copilot-route-inventory,ee/access-requestsandlib/core/applicationunit tests (334)bun run lint,check:api-validation:strict,check:boundaries,check:principal-kind-parity,check:application-graph,check:permission-group-enforcement,check:source-conventions,check:comment-hygiene, pre-pushtype-checkChecklist
test-auditauthoring gate)🤖 Generated with Claude Code