Repository navigation
implemented the zerocopy traits for smallVec - #819
Merged
Merged
Conversation
GauravPawar101
self-requested a review
October 29, 2026 17:16
alejandro-vaz
requested changes
Oct 29, 2026
Collaborator
|
review it as well @GauravPawar101, that way we get used to having multiple points of view which is always a plus |
Collaborator
|
Yeah, that's better |
GauravPawar101
suggested changes
Oct 29, 2026
Collaborator
|
@alejandro-vaz , I do not think we need a new file and also the zero function is sematically incorrect as according to https://docs.rs/zerocopy/latest/zerocopy/ the drop semantics are wrong. Also, it is provided by zeroize. |
alejandro-vaz
requested changes
Oct 29, 2026
Collaborator
|
I agree the |
Collaborator
|
also you have to run |
Contributor
Author
|
okay , working on the changes that you both have suggested |
Collaborator
|
you have to run |
GauravPawar101
suggested changes
Oct 30, 2026
GauravPawar101
suggested changes
Oct 31, 2026
Collaborator
|
All else is fine |
GauravPawar101
approved these changes
Oct 31, 2026
GauravPawar101
approved these changes
Oct 31, 2026
alejandro-vaz
requested changes
Oct 31, 2026
alejandro-vaz
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zerocopyas an optional dependency.SmallVecwith theGlobalallocator.Testing
cargo test --test zerocopy --features zerocopycargo test --libcargo test --test std --features stdCloses #796