Repository navigation
fix(bridge-history-api): bound request work and hide internal errors - #1825
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1825 +/- ##
===========================================
- Coverage 35.58% 35.55% -0.03%
===========================================
Files 263 263
Lines 22805 22824 +19
===========================================
Hits 8116 8116
- Misses 13837 13856 +19
Partials 852 852
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Purpose or design rationale of this PR
Tightens per-request limits in bridge-history-api. It also stops returning internal error details to clients.
Changes:
ShouldBindQuery) and never read a request body.txsbyhashesDB queries are capped at 500 rows per table. A request that exceeds the cap returns an error, so partial results are never returned or cached.errmsg: "internal error". The full error is still logged. Validation errors are unchanged.ContextWithFallback). A sharedsingleflightquery keeps running when one caller disconnects, with a 10 s timeout.GetTxsByHashesnow include the error.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit