Repository navigation
fix: restore unpatched SDK, read hash from RPC response - #1824
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1824 +/- ##
===========================================
+ Coverage 35.53% 35.58% +0.05%
===========================================
Files 263 263
Lines 22763 22805 +42
===========================================
+ Hits 8089 8116 +27
- Misses 13824 13837 +13
- Partials 850 852 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Purpose or design rationale of this PR
The gl2geth SDK computes wrong hashes for L1 blocks from Shanghai on. Its
Headerstruct follows Scroll L2 rules: it lacks newer L1 fields (e.g. EIP-7685requestsHash) and encodes Scroll-only fields afterbaseFee.bridge-history-apiworked around this with areplaceto an unmerged fork (scroll-tech/go-ethereum#1133). The rollup L1 watcher had no workaround, so it stored wrong hashes inl1_block.This PR:
eth_getBlockByNumberresponse in the bridge-history-api fetchers and the rollup L1 watcher.ethclientdid: required fields, a non-zero hash, and a transaction list that matchestransactionsRoot.replace. All modules now use the same SDK version.forbidigolint rule that forbidstypes.Header.Hashandtypes.Block.Hash. L2-only files are exempt, because the SDK hash is correct for L2.This unblocks the go-ethereum and Go version bumps.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit