Repository navigation
chore(deps): lock email-encoding 0.4.3 to match lettre 0.11.24 - #11
Open
gitfromwildan wants to merge 1 commit into
Open
gitfromwildan wants to merge 1 commit into
gitfromwildan wants to merge 1 commit into
Conversation
The lockfile pinned lettre 0.11.24 together with email-encoding 0.4.2, but lettre 0.11.24 requires email-encoding ^0.4.3. The lockfile was therefore inconsistent: any cargo command rewrote it, and --locked builds failed. CI did not catch it because no job passes --locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lockonmasteris inconsistent. It pinslettre0.11.24 together withemail-encoding0.4.2, butlettre0.11.24 requiresemail-encoding ^0.4.3. This PR locksemail-encoding0.4.3: one entry, two lines.Effect of the inconsistency
--lockedrewritesCargo.lock, so every checkout ends up with a modified lockfile after the first build.cargo metadata --locked(and any other--lockedbuild) fails onmasterwith "cannot update the lock file ... because --locked was passed".--locked; each run resolvesemail-encoding0.4.3 on the fly.The
lettrebump came in with #8 (chore(deps): bump lettre to 0.11.24 for RUSTSEC-2026-0560..0565), which updated thelettreentry but not its dependency.Testing
cargo metadata --lockedpasses with this change and fails without it.cargo test -p rustasea-mail --features smtp --lockedpasses (lettreis only linked behind that feature): 5 suites, 18 tests.cargo auditandcargo deny checkpass.email-encoding0.4.3 declaresrust-version = 1.85, under the workspace MSRV of 1.88.Not run: the full workspace test suite, since the change is one transitive dependency behind an opt-in feature.
Possible follow-up
Passing
--lockedin the CI jobs would turn this kind of drift into a failing check. I left that out because it changes the workflow rather than fixing the lockfile.@vheins, could you review this?