Skip to content

chore(deps): lock email-encoding 0.4.3 to match lettre 0.11.24 - #11

Open
gitfromwildan wants to merge 1 commit into
rustasea:masterfrom
gitfromwildan:fix/lockfile-email-encoding
Open

gitfromwildan wants to merge 1 commit into
rustasea:masterfrom
gitfromwildan:fix/lockfile-email-encoding

Conversation

@gitfromwildan

Copy link
Copy Markdown
Contributor

Summary

Cargo.lock on master is inconsistent. It pins lettre 0.11.24 together with email-encoding 0.4.2, but lettre 0.11.24 requires email-encoding ^0.4.3. This PR locks email-encoding 0.4.3: one entry, two lines.

Effect of the inconsistency

  • Any cargo command without --locked rewrites Cargo.lock, so every checkout ends up with a modified lockfile after the first build.
  • cargo metadata --locked (and any other --locked build) fails on master with "cannot update the lock file ... because --locked was passed".
  • CI does not catch it because no job passes --locked; each run resolves email-encoding 0.4.3 on the fly.

The lettre bump came in with #8 (chore(deps): bump lettre to 0.11.24 for RUSTSEC-2026-0560..0565), which updated the lettre entry but not its dependency.

Testing

  • cargo metadata --locked passes with this change and fails without it.
  • cargo test -p rustasea-mail --features smtp --locked passes (lettre is only linked behind that feature): 5 suites, 18 tests.
  • cargo audit and cargo deny check pass.
  • email-encoding 0.4.3 declares rust-version = 1.85, under the workspace MSRV of 1.88.

Not run: the full workspace test suite, since the change is one transitive dependency behind an opt-in feature.

Possible follow-up

Passing --locked in the CI jobs would turn this kind of drift into a failing check. I left that out because it changes the workflow rather than fixing the lockfile.

@vheins, could you review this?

The lockfile pinned lettre 0.11.24 together with email-encoding 0.4.2, but
lettre 0.11.24 requires email-encoding ^0.4.3. The lockfile was therefore
inconsistent: any cargo command rewrote it, and --locked builds failed.
CI did not catch it because no job passes --locked.
@github-actions
github-actions Bot requested a review from vheins November 19, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant