Skip to content

docs: follow the post-merge code in milestone status and parity - #10

Open
gitfromwildan wants to merge 1 commit into
rustasea:masterfrom
gitfromwildan:docs/sync-after-merge
Open

gitfromwildan wants to merge 1 commit into
rustasea:masterfrom
gitfromwildan:docs/sync-after-merge

Conversation

@gitfromwildan

@gitfromwildan gitfromwildan commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Documentation only. The fixes that landed on top of #7 and #8, and #9, moved or changed code that docs/milestones.md and docs/laravel-parity.md cite, so a few claims no longer matched master.

Changes

Citations that pointed at the wrong line (five targets, ten occurrences across docs/milestones.md, docs/laravel-parity.md, and .agents/documents/application/modules/identity-access/auth.md):

Target Was Now
bedrock_from_env in crates/rustasea-ai/src/providers/client.rs :376 :382
Embedding model resolution in the same file :313 :317
Embeddings request in crates/rustasea-ai/src/providers/openai.rs :155 :163
install_database_user_provider in crates/rustasea-app/src/bootstrap/auth.rs :320 :333
JwtGuard::logout in crates/rustasea-auth/src/jwt.rs :270 :267

Statements that no longer described the code:

  • A failed sync dispatch is dead-lettered through the configured default queue connection (database when the config names none), and reaches failed_jobs only when that connection's driver is the database driver. The documents said "the database connection".
  • The OpenAI embedding default applies only to OpenAI's own endpoint, not a custom OPENAI_BASE_URL.
  • A Bedrock embeddings call without BEDROCK_EMBEDDING_MODEL returns a configuration error.

How this was checked

  • For every path:line citation in docs/, .agents/, and the root Markdown files that points into a source file changed since the documents were written, I compared the cited line before and after. Those five targets are the only ones that moved.
  • Each new line number was read back against master.
  • cargo xtask lines:check passes. No source file is touched.

Not checked: citations into files that did not change in that range, and claims that carry no citation.

@vheins, could you review this?

The fixes that landed on top of rustasea#7 and rustasea#8, and rustasea#9, moved or changed code these
documents cite:

- Five path:line citations pointed at the wrong line (bedrock_from_env, the
  embedding model resolution and request, install_database_user_provider, and
  JwtGuard::logout).
- A failed sync dispatch is dead-lettered through the configured default queue
  connection, not a connection literally named database.
- The OpenAI embedding default applies only to OpenAI's own endpoint, and a
  Bedrock embeddings call without BEDROCK_EMBEDDING_MODEL is a configuration
  error.
@github-actions
github-actions Bot requested a review from vheins November 19, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant