Repository navigation
docs: follow the post-merge code in milestone status and parity - #10
Open
gitfromwildan wants to merge 1 commit into
Open
gitfromwildan wants to merge 1 commit into
gitfromwildan wants to merge 1 commit into
Conversation
The fixes that landed on top of rustasea#7 and rustasea#8, and rustasea#9, moved or changed code these documents cite: - Five path:line citations pointed at the wrong line (bedrock_from_env, the embedding model resolution and request, install_database_user_provider, and JwtGuard::logout). - A failed sync dispatch is dead-lettered through the configured default queue connection, not a connection literally named database. - The OpenAI embedding default applies only to OpenAI's own endpoint, and a Bedrock embeddings call without BEDROCK_EMBEDDING_MODEL is a configuration error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation only. The fixes that landed on top of #7 and #8, and #9, moved or changed code that
docs/milestones.mdanddocs/laravel-parity.mdcite, so a few claims no longer matchedmaster.Changes
Citations that pointed at the wrong line (five targets, ten occurrences across
docs/milestones.md,docs/laravel-parity.md, and.agents/documents/application/modules/identity-access/auth.md):bedrock_from_envincrates/rustasea-ai/src/providers/client.rs:376:382:313:317crates/rustasea-ai/src/providers/openai.rs:155:163install_database_user_providerincrates/rustasea-app/src/bootstrap/auth.rs:320:333JwtGuard::logoutincrates/rustasea-auth/src/jwt.rs:270:267Statements that no longer described the code:
syncdispatch is dead-lettered through the configured default queue connection (databasewhen the config names none), and reachesfailed_jobsonly when that connection's driver is the database driver. The documents said "thedatabaseconnection".OPENAI_BASE_URL.BEDROCK_EMBEDDING_MODELreturns a configuration error.How this was checked
path:linecitation indocs/,.agents/, and the root Markdown files that points into a source file changed since the documents were written, I compared the cited line before and after. Those five targets are the only ones that moved.master.cargo xtask lines:checkpasses. No source file is touched.Not checked: citations into files that did not change in that range, and claims that carry no citation.
@vheins, could you review this?