Repository navigation
Use libc::getrandom on Redox - #871
Merged
Merged
Conversation
josephlr
approved these changes
Oct 30, 2026
josephlr
left a comment
josephlr
left a comment
Member
There was a problem hiding this comment.
LGTM. I always love getting rid of a file-based backend.
|
|
||
| # redox | ||
| [target.'cfg(target_os = "redox")'.dependencies] | ||
| libc = { version = "0.2.190", default-features = false } |
Member
There was a problem hiding this comment.
Do we want to update the other libc versions now? Or in a later PR?
I don't think it really matters too much if they are in sync.
Member
Author
There was a problem hiding this comment.
I think it's fine to keep the old versions. It's technically more "correct" (since the other targets do not rely on features in new libc releases) and reduces amount of busywork.
Member
Author
There was a problem hiding this comment.
It seems that cargo is unable to select a smaller libc version if one of targets requires a higher one, so this change effectively bumps minimum version of libc for all targets.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #842