Skip to content

avx512ifma: fix docs for masked intrinsics - #2267

Merged
folkertdev merged 1 commit into
rust-lang:mainfrom
RalfJung:avx512ifma-mask
Nov 15, 2026
Merged

folkertdev merged 1 commit into
rust-lang:mainfrom
RalfJung:avx512ifma-mask

Conversation

@RalfJung

Copy link
Copy Markdown
Member

The current docs seem just wrong -- k is the mask, it has the wrong size to be the source of the output bits. The implementation is simd_select_bitmask(k, ..., a) and the last a means that that's what is used where k is 0.

@rustbot

rustbot commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev expanded to Amanieu, adamgemmell, davidtwco, folkertdev
  • Random selection from Amanieu, adamgemmell, davidtwco, folkertdev

@RalfJung

RalfJung commented Nov 15, 2026 •

Copy link
Copy Markdown
Member Author

That CI failure looks unrelated to my PR.

(This repo would benefit a lot from pinning the nightly rustc, to avoid PRs getting held up by unrelated breakage.)

@folkertdev

Copy link
Copy Markdown
Contributor

We just fixed that CI issue

@folkertdev folkertdev closed this Nov 15, 2026
@folkertdev folkertdev reopened this Nov 15, 2026
@folkertdev
folkertdev added this pull request to the merge queue Nov 15, 2026
Merged via the queue into rust-lang:main with commit cc846f6 Nov 15, 2026
91 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants